Skip to content

ci: don't report coverage data as json #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bagel897
Copy link
Contributor

@bagel897 bagel897 commented Feb 5, 2025

Contents

  • Remove refrences to old smart-tests flag
  • Don't report coverage to JSON or XML by default, let the codecov CLI handle that
  • Random SDK change to test CI

Results

  • Brings down full run from 11m to 6m

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files

@bagel897 bagel897 changed the title ci: fix double running and json report ci: don't report json coverage Feb 5, 2025
@bagel897 bagel897 changed the title ci: don't report json coverage ci: don't report coverage data as json Feb 5, 2025
@bagel897 bagel897 marked this pull request as ready for review February 5, 2025 19:51
@bagel897 bagel897 requested review from codegen-team and a team as code owners February 5, 2025 19:51
@bagel897 bagel897 requested review from rushilpatel0 and christinewangcw and removed request for a team February 5, 2025 19:51
@bagel897 bagel897 enabled auto-merge (squash) February 5, 2025 19:52
@bagel897 bagel897 disabled auto-merge February 5, 2025 20:12
@bagel897 bagel897 merged commit 3c0afce into develop Feb 5, 2025
22 of 26 checks passed
@bagel897 bagel897 deleted the eagarwal-cg-10685-optimize-unit-tests-duration-and-runner-size branch February 5, 2025 20:12
tkfoss pushed a commit that referenced this pull request Feb 6, 2025
# Contents
- Remove refrences to old smart-tests flag
- Don't report coverage to JSON or XML by default, let the codecov CLI
handle that
- Random SDK change to test CI
# Results
- Brings down full run from 11m to 6m
jayhack pushed a commit that referenced this pull request Feb 9, 2025
# Contents
- Remove refrences to old smart-tests flag
- Don't report coverage to JSON or XML by default, let the codecov CLI
handle that
- Random SDK change to test CI
# Results
- Brings down full run from 11m to 6m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants