Skip to content

ci: don't report coverage data as json #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .github/actions/run_ats/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ inputs:
default: ''
codecov_flags:
description: 'Flags for codecov upload'
required: false
default: 'smart-tests'
required: true

runs:
using: "composite"
Expand All @@ -44,7 +43,6 @@ runs:
- name: Run tests
shell: bash
run: |
echo "pwd: $(pwd)" # FIXME: for debugging
TESTS_TO_RUN=$(cat codecov_ats/tests_to_run.txt)
if [ -z "$TESTS_TO_RUN" ]; then
echo "No tests to run, skipping..."
Expand All @@ -56,7 +54,6 @@ runs:
-vv \
--cov \
--cov-append \
--cov-report=xml \
${{ inputs.collect_args }}

- uses: ./.github/actions/report
Expand Down
6 changes: 5 additions & 1 deletion .github/codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ component_management:
- type: patch
target: 50 # Language specific featues must be 100% covered
flags:
- smart-tests
- unit-tests
- component_id: codegen-sdk-typescript
name: codegen-sdk-typescript
paths:
Expand All @@ -27,10 +27,14 @@ component_management:
threshold: 0 # Shouldn't remove coverage
- type: patch
target: 50 # Language specific featues must be 100% covered
flags:
- unit-tests
- component_id: codegen-sdk-core
name: codegen-sdk-core
paths:
- src/codegen/sdk/**
flags:
- unit-tests

flag_management:
default_rules:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:

jobs:
unit-tests:
runs-on: ubuntu-latest-16
runs-on: ubuntu-latest-8
steps:
- uses: actions/checkout@v4
with:
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ pythonpath = "."
norecursedirs = "repos expected"
# addopts = -v --cov=app --cov-report=term

addopts = "--dist=loadgroup --junitxml=build/test-results/test/TEST.xml --strict-config --import-mode=importlib --cov-context=test --cov-report=json --cov-config=pyproject.toml -p no:doctest"
addopts = "--dist=loadgroup --junitxml=build/test-results/test/TEST.xml --strict-config --import-mode=importlib --cov-context=test --cov-config=pyproject.toml -p no:doctest"
filterwarnings = """
ignore::DeprecationWarning:botocore.*:
ignore::DeprecationWarning:sqlalchemy.*:
Expand Down
4 changes: 2 additions & 2 deletions src/codegen/sdk/core/import_resolution.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from abc import abstractmethod
from dataclasses import dataclass
from typing import TYPE_CHECKING, Generic, Literal, Self, TypeVar, override
from typing import TYPE_CHECKING, ClassVar, Generic, Literal, Self, TypeVar, override

from codegen.sdk.codebase.resolution_stack import ResolutionStack
from codegen.sdk.codebase.transactions import TransactionPriority
Expand Down Expand Up @@ -76,7 +76,7 @@ class Import(Usable[ImportStatement], Chainable, Generic[TSourceFile], HasAttrib
module: Editable | None
symbol_name: Editable | None
alias: Editable | None
node_type: Literal[NodeType.IMPORT] = NodeType.IMPORT
node_type: ClassVar[Literal[NodeType.IMPORT]] = NodeType.IMPORT
import_type: ImportType
import_statement: ImportStatement

Expand Down
Loading