Skip to content

add ruff rules and fix tests #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 29, 2025
Merged

add ruff rules and fix tests #183

merged 15 commits into from
Jan 29, 2025

Conversation

bagel897
Copy link
Contributor

Motivation

Content

Testing

Please check the following before marking your PR as ready for review

  • I have added tests for my changes
  • I have updated the documentation or added new documentation as needed
  • I have read and agree to the Contributor License Agreement

@bagel897 bagel897 requested review from codegen-team and a team as code owners January 29, 2025 19:00
@bagel897 bagel897 requested review from EdwardJXLi and removed request for a team January 29, 2025 19:00
@CLAassistant
Copy link

CLAassistant commented Jan 29, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ bagel897
❌ codegen-bot


codegen-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@eacodegen eacodegen requested a review from a team as a code owner January 29, 2025 19:01
@eacodegen eacodegen requested review from jemeza-codegen and removed request for a team January 29, 2025 19:01
@bagel897 bagel897 enabled auto-merge (squash) January 29, 2025 19:01
@bagel897 bagel897 changed the title add ruff rules add ruff rules and fix tests Jan 29, 2025
@bagel897 bagel897 disabled auto-merge January 29, 2025 21:59
@bagel897 bagel897 merged commit 58c7113 into develop Jan 29, 2025
6 of 9 checks passed
@bagel897 bagel897 deleted the eagarwal/add-ruff-rules2 branch January 29, 2025 22:00
jayhack pushed a commit that referenced this pull request Feb 9, 2025
# Motivation
<!-- Why is this change necessary? -->

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
- [ ] I have read and agree to the [Contributor License
Agreement](../CLA.md)

---------

Co-authored-by: codegen-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants