Skip to content

Add disable_graph Option / Feature Flag #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

EdwardJXLi
Copy link
Contributor

@EdwardJXLi EdwardJXLi commented Jan 29, 2025

Motivation

This adds the ability to turn off import and symbol resolution during codebase parsing. Motivation is to create a (more) lightweight editor for any file-independent changes that do not require the dependency or usage graph.

Prelim testing shows a 25% - 35% in memory usage as well as a 65%-85% reduction in parse times.

@EdwardJXLi EdwardJXLi requested review from codegen-team and a team as code owners January 29, 2025 23:01
@EdwardJXLi EdwardJXLi requested review from bagel897 and removed request for a team January 29, 2025 23:01
@CLAassistant
Copy link

CLAassistant commented Jan 29, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ EdwardJXLi
❌ codegen-bot


codegen-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@EdwardJXLi EdwardJXLi merged commit 81d0147 into develop Jan 29, 2025
7 of 8 checks passed
@EdwardJXLi EdwardJXLi deleted the eli-cg-10572-enable-codebase-importsfalse branch January 29, 2025 23:13
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/codegen/sdk/codebase/codebase_graph.py 92.59% 2 Missing ⚠️
Additional details and impacted files

jayhack pushed a commit that referenced this pull request Feb 9, 2025
# Motivation

This adds the ability to turn off import and symbol resolution during
codebase parsing. Motivation is to create a (more) lightweight editor
for any file-independent changes that do not require the dependency or
usage graph.

Prelim testing shows a 25% - 35% in memory usage as well as a 65%-85%
reduction in parse times.

Co-authored-by: codegen-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants