Skip to content

Bug fix: Create command response access #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

rushilpatel0
Copy link
Contributor

@rushilpatel0 rushilpatel0 commented Jan 29, 2025

Motivation

Bug in the implementation for the create command where a variable was accessed outside the scope it was defined

Content

Testing

Please check the following before marking your PR as ready for review

  • I have added tests for my changes
  • I have updated the documentation or added new documentation as needed
  • I have read and agree to the Contributor License Agreement

@CLAassistant
Copy link

CLAassistant commented Jan 29, 2025

CLA assistant check
All committers have signed the CLA.

@rushilpatel0 rushilpatel0 marked this pull request as ready for review January 29, 2025 23:11
@rushilpatel0 rushilpatel0 requested review from codegen-team and a team as code owners January 29, 2025 23:11
@rushilpatel0 rushilpatel0 requested review from EdwardJXLi and removed request for a team January 29, 2025 23:11
@rushilpatel0 rushilpatel0 changed the title Create commnad response access Bug fix: Create command response access Jan 29, 2025
Copy link
Contributor

@jemeza-codegen jemeza-codegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, worked locally

@rushilpatel0 rushilpatel0 merged commit cb09b14 into develop Jan 29, 2025
7 of 9 checks passed
@rushilpatel0 rushilpatel0 deleted the rpatel/fix-create-response branch January 29, 2025 23:16
jayhack pushed a commit that referenced this pull request Feb 9, 2025
# Motivation
<!-- Why is this change necessary? -->
Bug in the implementation for the `create` command where a variable was
accessed outside the scope it was defined
# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
- [ ] I have read and agree to the [Contributor License
Agreement](../CLA.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants