Skip to content

Add test #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Add test #251

merged 3 commits into from
Feb 3, 2025

Conversation

bagel897
Copy link
Contributor

@bagel897 bagel897 commented Feb 3, 2025

Motivation

Content

Testing

Please check the following before marking your PR as ready for review

  • I have added tests for my changes
  • I have updated the documentation or added new documentation as needed

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files

@bagel897 bagel897 marked this pull request as ready for review February 3, 2025 17:52
@bagel897 bagel897 requested review from codegen-team and a team as code owners February 3, 2025 17:52
@bagel897 bagel897 requested review from EdwardJXLi and removed request for a team February 3, 2025 17:52
@bagel897 bagel897 merged commit 38983ef into develop Feb 3, 2025
20 checks passed
@bagel897 bagel897 deleted the eagarwal/add-module-function-test branch February 3, 2025 17:53
@@ -35,7 +35,7 @@ jobs:
path: ~/.cache/pre-commit
key: pre-commit|${{ env.pythonLocation }}|${{ hashFiles('.pre-commit-config.yaml') }}

- run: uv run --frozen pre-commit run --show-diff-on-failure --color=always --all-files --source ${{ github.event.pull_request.base.sha }} --origin ${{github.event.pull_request.head.sha }} --show-diff-on-failure --color=always
- run: SKIP=disallowed-words-check uv run --frozen pre-commit run --show-diff-on-failure --color=always --all-files --source ${{ github.event.pull_request.base.sha }} --origin ${{github.event.pull_request.head.sha }} --show-diff-on-failure --color=always

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use the envvar instead?

jayhack pushed a commit that referenced this pull request Feb 9, 2025
# Motivation
<!-- Why is this change necessary? -->

# Content
<!-- Please include a summary of the change -->
# Testing
<!-- How was the change tested? -->
# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants