Skip to content

Refactor & Standardize Tests for move_to_file #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

EdwardJXLi
Copy link
Contributor

Motivation

Content

Testing

Please check the following before marking your PR as ready for review

  • I have added tests for my changes
  • I have updated the documentation or added new documentation as needed

@EdwardJXLi EdwardJXLi requested review from codegen-team and a team as code owners February 4, 2025 00:24
@EdwardJXLi EdwardJXLi requested review from bagel897 and removed request for a team February 4, 2025 00:24
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 95.87629% with 16 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../sdk/python/function/test_function_move_to_file.py 91.57% 16 Missing ⚠️
Additional details and impacted files

@EdwardJXLi EdwardJXLi requested a review from bagel897 February 4, 2025 18:57
@EdwardJXLi EdwardJXLi merged commit e049dc8 into develop Feb 4, 2025
28 of 33 checks passed
@EdwardJXLi EdwardJXLi deleted the eli-cg-10598-refactor-standardize-test_function_move_to_filepy branch February 4, 2025 19:06
jayhack pushed a commit that referenced this pull request Feb 9, 2025
# Motivation

<!-- Why is this change necessary? -->

# Content

<!-- Please include a summary of the change -->

# Testing

<!-- How was the change tested? -->

# Please check the following before marking your PR as ready for review

- [ ] I have added tests for my changes
- [ ] I have updated the documentation or added new documentation as
needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants