-
Notifications
You must be signed in to change notification settings - Fork 52
feat: [CG-10650] codebase.codeowners interface #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [CG-10650] codebase.codeowners interface #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add some unit tests?
yep will add tests if this is what we're looking for, but it looks we want to be able to access symbols as well.
|
As a side note, I feel like:
we can have a types module to store and import these from |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
@bagel897 @EdwardJXLi what do ya'll think about this refactor for this "directory-like" API referred to in the ticket ? |
unit tests are wip |
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Motivation
Easier access to code owners of a codebase and files owned by them.
Content
Introduces CodeOwner class and codeowners property on the Codebase class. Refactored methods around source file inspection into a separate base class for other file container interfaces in the futures.
Testing
Testing WIP.
Please check the following before marking your PR as ready for review