Skip to content

Add missing ExternalModule import #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

jmvldz
Copy link
Contributor

@jmvldz jmvldz commented Feb 5, 2025

Motivation

The code example is missing this import.

Content

Add missing import to code example.

Testing

Tested the code in a codegen script.

Please check the following before marking your PR as ready for review

  • I have added tests for my changes
  • I have updated the documentation or added new documentation as needed

@jmvldz jmvldz requested review from codegen-team and a team as code owners February 5, 2025 05:17
@jmvldz jmvldz requested review from rushilpatel0 and removed request for a team February 5, 2025 05:17
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@jayhack jayhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmvldz !

@jayhack jayhack merged commit f3e95e1 into codegen-sh:develop Feb 5, 2025
4 of 11 checks passed
jayhack pushed a commit that referenced this pull request Feb 9, 2025
# Motivation

The code example is missing this import.

# Content

Add missing import to code example.

# Testing

Tested the code in a codegen script.

# Please check the following before marking your PR as ready for review

- [X] I have added tests for my changes
- [X] I have updated the documentation or added new documentation as
needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants