Skip to content

Feature flag generics support #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2025
Merged

Feature flag generics support #304

merged 2 commits into from
Feb 5, 2025

Conversation

bagel897
Copy link
Contributor

@bagel897 bagel897 commented Feb 5, 2025

No description provided.

@bagel897 bagel897 marked this pull request as ready for review February 5, 2025 18:14
@bagel897 bagel897 requested review from codegen-team and a team as code owners February 5, 2025 18:14
@bagel897 bagel897 requested review from rushilpatel0 and removed request for a team February 5, 2025 18:14
@bagel897 bagel897 enabled auto-merge (squash) February 5, 2025 18:14
@codecov Codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...codegen/sdk/core/detached_symbols/function_call.py 81.81% 2 Missing ⚠️
Additional details and impacted files

@bagel897 bagel897 merged commit 86fda48 into develop Feb 5, 2025
30 of 32 checks passed
@bagel897 bagel897 deleted the eagarwal/fix-mypy branch February 5, 2025 18:28
tkfoss pushed a commit that referenced this pull request Feb 6, 2025
@bagel897
Feature flag generics support (#304)
4aa7676
jayhack pushed a commit that referenced this pull request Feb 9, 2025
@bagel897
Feature flag generics support (#304)
14198fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdwardJXLi EdwardJXLi EdwardJXLi approved these changes

@codegen-team codegen-team Awaiting requested review from codegen-team codegen-team is a code owner

@rushilpatel0 rushilpatel0 Awaiting requested review from rushilpatel0 rushilpatel0 is a code owner automatically assigned from codegen-sh/codegen-sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bagel897 @EdwardJXLi