Skip to content

CG-10430: removes call_graph_successors #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

jemeza-codegen
Copy link
Contributor

Motivation

Simplifies API

Content

removed call_graph_successors() method of Callable

Testing

Updated Pytest

Please check the following before marking your PR as ready for review

  • I have added tests for my changes
  • I have updated the documentation or added new documentation as needed
  • I have read and agree to the Contributor License Agreement

@jemeza-codegen jemeza-codegen requested review from codegen-team and a team as code owners January 23, 2025 19:23
@jemeza-codegen jemeza-codegen requested review from jayhack and tawsifkamal and removed request for a team January 23, 2025 19:23
Copy link

linear bot commented Jan 23, 2025

CG-10430 Remove `call_graph_successors`

  • This is no longer the best way to do successors

Context: https://thecodegen.slack.com/archives/D06SQUYP084/p1737502890496439?thread_ts=1737502828.346789&cid=D06SQUYP084

This can be deprecated in favor of function_calls

@jemeza-codegen jemeza-codegen merged commit 9b6d7c6 into develop Jan 23, 2025
7 of 12 checks passed
@jemeza-codegen jemeza-codegen deleted the remove-call-graph-successor branch January 23, 2025 21:45
jayhack pushed a commit that referenced this pull request Feb 9, 2025
# Motivation
Simplifies API

# Content
removed `call_graph_successors()` method of `Callable`
# Testing
Updated Pytest
# Please check the following before marking your PR as ready for review

- [x] I have added tests for my changes
- [x] I have updated the documentation or added new documentation as
needed
- [x] I have read and agree to the [Contributor License
Agreement](../CLA.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants