Skip to content

CG-10697: TS-Promise-Chain #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 18, 2025
Merged

CG-10697: TS-Promise-Chain #417

merged 13 commits into from
Feb 18, 2025

Conversation

tawsifkamal
Copy link
Contributor

@tawsifkamal tawsifkamal commented Feb 11, 2025 •
edited
Loading

  • Adds TSPromise class to help deal with promises more easily
  • adds ability to retreive TSPromiseChain from a functionCall node
  • convert to async/await blog
  • convert to async/await tutorial
  • convert to async/await example folder

@tawsifkamal tawsifkamal requested review from codegen-team and a team as code owners February 11, 2025 16:52
@codecov Codecov
Copy link

codecov bot commented Feb 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.99756% with 45 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...n/sdk/typescript/detached_symbols/promise_chain.py 84.87% 44 Missing ⚠️
...codegen/sdk/core/detached_symbols/function_call.py 85.71% 1 Missing ⚠️
Additional details and impacted files

bagel897
bagel897 suggested changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@bagel897 bagel897 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now it's pretty unreadable, can we move the type hints and make the code more readable please?

tawsifkamal
tawsifkamal commented Feb 18, 2025
View reviewed changes
eacodegen
eacodegen suggested changes Feb 18, 2025
View reviewed changes
src/codegen/sdk/core/detached_symbols/promise_chain.py Outdated
parent_class: Class
declared_vars: set[str]
base_indent: str
name: str | None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should inherit from editable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And HasName

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note that this will be dealt with future changes

@tawsifkamal tawsifkamal merged commit 6707a50 into develop Feb 18, 2025
23 of 26 checks passed
@tawsifkamal tawsifkamal deleted the tawsif-ts-promise branch February 18, 2025 21:00
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 0.21.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagel897 bagel897 bagel897 requested changes

@eacodegen eacodegen eacodegen requested changes

@codegen-team codegen-team Awaiting requested review from codegen-team codegen-team is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tawsifkamal @bagel897 @eacodegen