chore: raise exception if user is on default branch + tries to create the PR

src/codegen/sdk/core/codebase.py

@@ -176,13 +176,13 @@
             main_project = ProjectConfig.from_path(repo_path, programming_language=programming_language)
             projects = [main_project]
         else:
             main_project = projects[0]
 
         # Initialize codebase
         self._op = main_project.repo_operator
         self.viz = VisualizationManager(op=self._op)
         self.repo_path = Path(self._op.repo_path)
         self.ctx = CodebaseContext(projects, config=config, io=io)
         self.console = Console(record=True, soft_wrap=True)
 
     @noapidoc
@@ -198,7 +198,7 @@
         yield "nodes", len(self.ctx.nodes)
         yield "edges", len(self.ctx.edges)
 
     __rich_repr__.angular = ANGULAR_STYLE
 
     @property
     @deprecated("Please do not use the local repo operator directly")
@@ -226,8 +226,8 @@
 
     @noapidoc
     def _symbols(self, symbol_type: SymbolType | None = None) -> list[TSymbol | TClass | TFunction | TGlobalVar]:
         matches: list[Symbol] = self.ctx.get_nodes(NodeType.SYMBOL)
         return [x for x in matches if x.is_top_level and (symbol_type is None or x.symbol_type == symbol_type)]
 
     # =====[ Node Types ]=====
     @overload
@@ -236,7 +236,7 @@
     def files(self, *, extensions: Literal["*"]) -> list[File]: ...
     @overload
     def files(self, *, extensions: None = ...) -> list[TSourceFile]: ...
     @proxy_property
     def files(self, *, extensions: list[str] | Literal["*"] | None = None) -> list[TSourceFile] | list[File]:
         """A list property that returns all files in the codebase.
 
@@ -266,15 +266,15 @@
         return sort_editables(files, alphabetical=True, dedupe=False)
 
     @cached_property
     def codeowners(self) -> list["CodeOwner[TSourceFile]"]:
         """List all CodeOnwers in the codebase.
 
         Returns:
             list[CodeOwners]: A list of CodeOwners objects in the codebase.
         """
         if self.G.codeowners_parser is None:
             return []
         return CodeOwner.from_parser(self.G.codeowners_parser, lambda *args, **kwargs: self.files(*args, **kwargs))
 
     @property
     def directories(self) -> list[TDirectory]:
@@ -286,7 +286,7 @@
         Returns:
             list[TDirectory]: A list of Directory objects in the codebase.
         """
         return list(self.ctx.directories.values())
 
     @property
     def imports(self) -> list[TImport]:
@@ -902,6 +902,9 @@
         if self._op.git_cli.head.is_detached:
             msg = "Cannot make a PR from a detached HEAD"
             raise ValueError(msg)
+        if self._op.git_cli.active_branch.name == self._op.default_branch:
+            msg = "Cannot make a PR from the default branch"
+            raise ValueError(msg)
         self._op.stage_and_commit_all_changes(message=title)
         self._op.push_changes()
         return self._op.remote_git_repo.create_pull(head_branch_name=self._op.git_cli.active_branch.name, base_branch_name=self._op.default_branch, title=title, body=body)

tests/integration/codegen/git/codebase/test_codebase_create_pr.py

@@ -8,7 +8,8 @@
 def test_codebase_create_pr_active_branch(codebase: Codebase):
     head = f"test-create-pr-{uuid.uuid4()}"
     codebase.checkout(branch=head, create_if_missing=True)
-    codebase.files[0].remove()
+    file = codebase.files[0]
+    file.remove()
     codebase.commit()
     pr = codebase.create_pr(title="test-create-pr title", body="test-create-pr body")
     assert pr.title == "test-create-pr title"
@@ -17,10 +18,21 @@ def test_codebase_create_pr_active_branch(codebase: Codebase):
     assert pr.state == "open"
     assert pr.head.ref == head
     assert pr.base.ref == "main"
+    assert pr.get_files().totalCount == 1
+    assert pr.get_files()[0].filename == file.file_path
 
 
 def test_codebase_create_pr_detached_head(codebase: Codebase):
     codebase.checkout(commit=codebase._op.git_cli.head.commit)  # move to detached head state
     with pytest.raises(ValueError) as exc_info:
         codebase.create_pr(title="test-create-pr title", body="test-create-pr body")
     assert "Cannot make a PR from a detached HEAD" in str(exc_info.value)
+
+
+def test_codebase_create_pr_active_branch_is_default_branch(codebase: Codebase):
+    codebase.checkout(branch=codebase._op.default_branch)
+    codebase.files[0].remove()
+    codebase.commit()
+    with pytest.raises(ValueError) as exc_info:
+        codebase.create_pr(title="test-create-pr title", body="test-create-pr body")
+    assert "Cannot make a PR from the default branch" in str(exc_info.value)