[CG-10829] fix: import wildcard doesn't preserve import resolution #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagel897
approved these changes
Feb 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files |
tkfoss
changed the title
tkfoss
deleted the
tom-cg-10829-import-wildcard-doesnt-preserve-import-resolution
branch
|
🎉 This PR is included in version 0.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
rushilpatel0
pushed a commit
that referenced
this pull request
Feb 18, 2025
) Importing from a file that contains a wildcard can break further resolution. This could occur depending on to_resolve ordering, if the outer file is processed first _wildcards will not be filled in time. --------- Co-authored-by: tomcodegen <[email protected]> Co-authored-by: tomcodgen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Content
Testing
Please check the following before marking your PR as ready for review