Skip to content

Ignore compiled and minified javascript files #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Ignore compiled and minified javascript files #606

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a7743d
Ignore compiled and minified javascript files
EdwardJXLi Feb 21, 2025
75bef7d
Automated pre-commit update
EdwardJXLi Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/codegen/sdk/codebase/codebase_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@
".*/tests/static/chunk-.*.js",
".*/ace/.*.js",
"src/vs/platform/contextview/browser/contextMenuService.ts",
"*/compiled/*",
"*/*.min.js",
]


Expand Down Expand Up @@ -212,7 +214,7 @@
syncs[SyncType.ADD].append(self.to_absolute(filepath))
logger.info(f"> Parsing {len(syncs[SyncType.ADD])} files in {self.projects[0].subdirectories or 'ALL'} subdirectories with {self.extensions} extensions")
self._process_diff_files(syncs, incremental=False)
files: list[SourceFile] = self.get_nodes(NodeType.FILE)

Check failure on line 217 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Incompatible types in assignment (expression has type "list[Importable[Any]]", variable has type "list[SourceFile[Any, Any, Any, Any, Any, Any]]")  [assignment]
logger.info(f"> Found {len(files)} files")
logger.info(f"> Found {len(self.nodes)} nodes and {len(self.edges)} edges")
if self.config.track_graph:
Expand Down Expand Up @@ -242,8 +244,8 @@
elif diff.change_type == ChangeType.Modified:
files_to_sync[filepath] = SyncType.REPARSE
elif diff.change_type == ChangeType.Renamed:
files_to_sync[diff.rename_from] = SyncType.DELETE

Check failure on line 247 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Invalid index type "Path | None" for "dict[Path, SyncType]"; expected type "Path"  [index]
files_to_sync[diff.rename_to] = SyncType.ADD

Check failure on line 248 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Invalid index type "Path | None" for "dict[Path, SyncType]"; expected type "Path"  [index]
elif diff.change_type == ChangeType.Removed:
files_to_sync[filepath] = SyncType.DELETE
else:
Expand Down Expand Up @@ -280,16 +282,16 @@
files_to_write.append((sync.path, sync.old_content))
modified_files.add(sync.path)
elif sync.change_type == ChangeType.Renamed:
files_to_write.append((sync.rename_from, sync.old_content))

Check failure on line 285 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Argument 1 to "append" of "list" has incompatible type "tuple[Path | None, bytes | None]"; expected "tuple[Path, bytes | None]"  [arg-type]
files_to_remove.append(sync.rename_to)
modified_files.add(sync.rename_from)

Check failure on line 287 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Argument 1 to "add" of "set" has incompatible type "Path | None"; expected "Path"  [arg-type]
modified_files.add(sync.rename_to)

Check failure on line 288 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Argument 1 to "add" of "set" has incompatible type "Path | None"; expected "Path"  [arg-type]
elif sync.change_type == ChangeType.Added:
files_to_remove.append(sync.path)
modified_files.add(sync.path)
logger.info(f"Writing {len(files_to_write)} files to disk and removing {len(files_to_remove)} files")
for file in files_to_remove:
self.io.delete_file(file)

Check failure on line 294 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Argument 1 to "delete_file" of "IO" has incompatible type "Path | None"; expected "Path"  [arg-type]
to_save = set()
for file, content in files_to_write:
self.io.write_file(file, content)
Expand Down Expand Up @@ -340,7 +342,7 @@
for module in external_modules:
if not any(self.predecessors(module.node_id)):
self.remove_node(module.node_id)
self._ext_module_idx.pop(module._idx_key, None)

Check failure on line 345 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: "Importable[Any]" has no attribute "_idx_key"  [attr-defined]

def build_directory_tree(self, files: list[SourceFile]) -> None:
"""Builds the directory tree for the codebase"""
Expand All @@ -349,7 +351,7 @@
created_dirs = set()
for file in files:
directory = self.get_directory(file.path.parent, create_on_missing=True)
directory.add_file(file)

Check failure on line 354 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Item "None" of "Directory[Any, Any, Any, Any, Any, Any, Any] | None" has no attribute "add_file"  [union-attr]
file._set_directory(directory)
created_dirs.add(file.path.parent)

Expand All @@ -376,7 +378,7 @@
If create_on_missing is set, use a recursive strategy to create the directory object and all subdirectories.
"""
# If not part of repo path, return None
absolute_path = self.to_absolute(directory_path)

Check failure on line 381 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Argument 1 to "__call__" of "_lru_cache_wrapper" has incompatible type "PathLike[Any]"; expected "Hashable"  [arg-type]
if not self.is_subdir(absolute_path):
assert False, f"Directory {absolute_path} is not part of repo path {self.repo_path}"
return None
Expand Down