Skip to content

fix: remove build_graph transaction #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025
Merged

fix: remove build_graph transaction #971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/codegen/sdk/codebase/codebase_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
from codegen.shared.enums.programming_language import ProgrammingLanguage
from codegen.shared.exceptions.control_flow import StopCodemodException
from codegen.shared.logging.get_logger import get_logger
from codegen.shared.performance.stopwatch_utils import stopwatch, stopwatch_with_sentry
from codegen.shared.performance.stopwatch_utils import stopwatch

if TYPE_CHECKING:
from collections.abc import Generator, Mapping, Sequence
Expand Down Expand Up @@ -215,7 +215,7 @@
def __repr__(self):
return self.__class__.__name__

@property

Check failure on line 218 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Name "_graph" already defined on line 124  [no-redef]
def _graph(self) -> PyDiGraph[Importable, Edge]:
if not self.__graph_ready:
logger.info("Lazily Computing Graph")
Expand All @@ -226,7 +226,7 @@
def _graph(self, value: PyDiGraph[Importable, Edge]) -> None:
self.__graph = value

@stopwatch_with_sentry(name="build_graph")
@stopwatch
@commiter
def build_graph(self, repo_operator: RepoOperator) -> None:
"""Builds a codebase graph based on the current file state of the given repo operator"""
Expand All @@ -242,7 +242,7 @@
syncs[SyncType.ADD].append(self.to_absolute(filepath))
logger.info(f"> Parsing {len(syncs[SyncType.ADD])} files in {self.projects[0].subdirectories or 'ALL'} subdirectories with {self.extensions} extensions")
self._process_diff_files(syncs, incremental=False)
files: list[SourceFile] = self.get_nodes(NodeType.FILE)

Check failure on line 245 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Incompatible types in assignment (expression has type "list[Importable[Any]]", variable has type "list[SourceFile[Any, Any, Any, Any, Any, Any]]")  [assignment]
logger.info(f"> Found {len(files)} files")
logger.info(f"> Found {len(self.nodes)} nodes and {len(self.edges)} edges")
if self.config.track_graph:
Expand Down Expand Up @@ -272,8 +272,8 @@
elif diff.change_type == ChangeType.Modified:
files_to_sync[filepath] = SyncType.REPARSE
elif diff.change_type == ChangeType.Renamed:
files_to_sync[diff.rename_from] = SyncType.DELETE

Check failure on line 275 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Invalid index type "Path | None" for "dict[Path, SyncType]"; expected type "Path"  [index]
files_to_sync[diff.rename_to] = SyncType.ADD

Check failure on line 276 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Invalid index type "Path | None" for "dict[Path, SyncType]"; expected type "Path"  [index]
elif diff.change_type == ChangeType.Removed:
files_to_sync[filepath] = SyncType.DELETE
else:
Expand Down Expand Up @@ -313,16 +313,16 @@
files_to_write.append((sync.path, sync.old_content))
modified_files.add(sync.path)
elif sync.change_type == ChangeType.Renamed:
files_to_write.append((sync.rename_from, sync.old_content))

Check failure on line 316 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Argument 1 to "append" of "list" has incompatible type "tuple[Path | None, bytes | None]"; expected "tuple[Path, bytes | None]"  [arg-type]
files_to_remove.append(sync.rename_to)
modified_files.add(sync.rename_from)

Check failure on line 318 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Argument 1 to "add" of "set" has incompatible type "Path | None"; expected "Path"  [arg-type]
modified_files.add(sync.rename_to)

Check failure on line 319 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Argument 1 to "add" of "set" has incompatible type "Path | None"; expected "Path"  [arg-type]
elif sync.change_type == ChangeType.Added:
files_to_remove.append(sync.path)
modified_files.add(sync.path)
logger.info(f"Writing {len(files_to_write)} files to disk and removing {len(files_to_remove)} files")
for file in files_to_remove:
self.io.delete_file(file)

Check failure on line 325 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Argument 1 to "delete_file" of "IO" has incompatible type "Path | None"; expected "Path"  [arg-type]
to_save = set()
for file, content in files_to_write:
self.io.write_file(file, content)
Expand Down Expand Up @@ -373,7 +373,7 @@
for module in external_modules:
if not any(self.predecessors(module.node_id)):
self.remove_node(module.node_id)
self._ext_module_idx.pop(module._idx_key, None)

Check failure on line 376 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: "Importable[Any]" has no attribute "_idx_key"  [attr-defined]

def build_directory_tree(self) -> None:
"""Builds the directory tree for the codebase"""
Expand All @@ -385,7 +385,7 @@
ignore_list=GLOBAL_FILE_IGNORE_LIST,
skip_content=True,
):
file_path = Path(file_path)

Check failure on line 388 in src/codegen/sdk/codebase/codebase_context.py

View workflow job for this annotation

GitHub Actions / mypy 

error: Incompatible types in assignment (expression has type "Path", variable has type "str")  [assignment]
directory = self.get_directory(file_path.parent, create_on_missing=True)
directory._add_file(file_path.name)

Expand Down