-
Notifications
You must be signed in to change notification settings - Fork 52
Adds missing return types, Styling modifications (CG-10500, CG-10499, CG-10498) #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayhack
approved these changes
Jan 26, 2025
eacodegen
pushed a commit
that referenced
this pull request
Jan 27, 2025
… CG-10498) (#98) # Motivation Methods were missing return types, visibility of types in docs in light mode was unsatisfactory # Content <!-- Please include a summary of the change --> # Testing <!-- How was the change tested? --> # Please check the following before marking your PR as ready for review - [x] I have added tests for my changes - [x] I have updated the documentation or added new documentation as needed - [x] I have read and agree to the [Contributor License Agreement](../CLA.md) --------- Co-authored-by: Jay Hack <[email protected]> Co-authored-by: codegen-bot <[email protected]>
tkfoss
pushed a commit
that referenced
this pull request
Jan 28, 2025
… CG-10498) (#98) # Motivation Methods were missing return types, visibility of types in docs in light mode was unsatisfactory # Content <!-- Please include a summary of the change --> # Testing <!-- How was the change tested? --> # Please check the following before marking your PR as ready for review - [x] I have added tests for my changes - [x] I have updated the documentation or added new documentation as needed - [x] I have read and agree to the [Contributor License Agreement](../CLA.md) --------- Co-authored-by: Jay Hack <[email protected]> Co-authored-by: codegen-bot <[email protected]>
jayhack
added a commit
that referenced
this pull request
Feb 9, 2025
… CG-10498) (#98) # Motivation Methods were missing return types, visibility of types in docs in light mode was unsatisfactory # Content <!-- Please include a summary of the change --> # Testing <!-- How was the change tested? --> # Please check the following before marking your PR as ready for review - [x] I have added tests for my changes - [x] I have updated the documentation or added new documentation as needed - [x] I have read and agree to the [Contributor License Agreement](../CLA.md) --------- Co-authored-by: Jay Hack <[email protected]> Co-authored-by: codegen-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Methods were missing return types, visibility of types in docs in light mode was unsatisfactory
Content
Testing
Please check the following before marking your PR as ready for review