Skip to content

Commit bae9665

Browse files
authored
Merge pull request #6446 from kenjis/update-composer-scripts
chore: update composer scripts
2 parents 2788a49 + a589af0 commit bae9665

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

composer.json

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,11 @@
7070
"CodeIgniter\\ComposerScripts::postUpdate",
7171
"bash -c \"if [ -f admin/setup.sh ]; then bash admin/setup.sh; fi\""
7272
],
73-
"analyze": "phpstan analyse",
73+
"analyze": [
74+
"phpstan analyze",
75+
"rector process --dry-run"
76+
],
77+
"sa": "@analyze",
7478
"test": "phpunit",
7579
"cs": [
7680
"php-cs-fixer fix --ansi --verbose --dry-run --diff --config=.php-cs-fixer.user-guide.php",
@@ -81,7 +85,8 @@
8185
"php-cs-fixer fix --ansi --verbose --diff --config=.php-cs-fixer.user-guide.php",
8286
"php-cs-fixer fix --ansi --verbose --diff --config=.php-cs-fixer.no-header.php",
8387
"php-cs-fixer fix --ansi --verbose --diff"
84-
]
88+
],
89+
"style": "@cs-fix"
8590
},
8691
"scripts-descriptions": {
8792
"analyze": "Run static analysis",

contributing/pull_request.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,6 @@ The best way to contribute is to fork the CodeIgniter4 repository, and "clone" t
252252
- Commit messages are expected to be descriptive of why and what you changed specifically. Commit messages like "Fixes #1234" would be asked by the reviewer to be revised. [Atomic commit](https://en.wikipedia.org/wiki/Atomic_commit#Atomic_commit_convention) is recommended. See [Contribution Workflow](./workflow.md#commit-messages) for details.
253253
9. If you have touched PHP code, run static analysis.
254254
- `> composer analyze`
255-
- `> vendor/bin/rector process`
256255
10. Run unit tests on the specific file you modified. If there are no existing tests yet, please create one.
257256
- `> vendor/bin/phpunit tests/system/path/to/file/you/modified`
258257
- Make sure the tests pass to have a higher chance of merging.

0 commit comments

Comments
 (0)