refactor: fix @readonly property errors (#9529)

paulbalandan · web-flow · commit bbb65b0af422 · 2025-04-19T16:35:52.000+08:00
diff --git a/app/Config/Autoload.php b/app/Config/Autoload.php
@@ -17,8 +17,6 @@
  *
  * NOTE: This class is required prior to Autoloader instantiation,
  *       and does not extend BaseConfig.
- *
- * @immutable
  */
 class Autoload extends AutoloadConfig
 {
diff --git a/app/Config/DocTypes.php b/app/Config/DocTypes.php
@@ -2,9 +2,6 @@
 
 namespace Config;
 
-/**
- * @immutable
- */
 class DocTypes
 {
     /**
diff --git a/app/Config/Mimes.php b/app/Config/Mimes.php
@@ -3,8 +3,6 @@
 namespace Config;
 
 /**
- * Mimes
- *
  * This file contains an array of mime types.  It is used by the
  * Upload class to help identify allowed file types.
  *
@@ -15,8 +13,6 @@
  *
  * When working with mime types, please make sure you have the ´fileinfo´
  * extension enabled to reliably detect the media types.
- *
- * @immutable
  */
 class Mimes
 {
diff --git a/app/Config/Modules.php b/app/Config/Modules.php
@@ -9,8 +9,6 @@
  *
  * NOTE: This class is required prior to Autoloader instantiation,
  *       and does not extend BaseConfig.
- *
- * @immutable
  */
 class Modules extends BaseModules
 {
diff --git a/app/Config/Optimize.php b/app/Config/Optimize.php
@@ -7,8 +7,6 @@
  *
  * NOTE: This class does not extend BaseConfig for performance reasons.
  *       So you cannot replace the property values with Environment Variables.
- *
- * @immutable
  */
 class Optimize
 {
diff --git a/app/Config/Paths.php b/app/Config/Paths.php
@@ -15,8 +15,6 @@
  *
  * NOTE: This class is required prior to Autoloader instantiation,
  *       and does not extend BaseConfig.
- *
- * @immutable
  */
 class Paths
 {
diff --git a/utils/phpstan-baseline/loader.neon b/utils/phpstan-baseline/loader.neon
@@ -1,4 +1,4 @@
-# total 3511 errors
+# total 3458 errors
 includes:
     - argument.type.neon
     - assign.propertyType.neon
@@ -27,8 +27,6 @@ includes:
     - property.nonObject.neon
     - property.notFound.neon
     - property.phpDocType.neon
-    - property.readOnlyByPhpDocAssignOutOfClass.neon
-    - property.readOnlyByPhpDocDefaultValue.neon
     - staticMethod.notFound.neon
     - ternary.shortNotAllowed.neon
     - varTag.type.neon
diff --git a/utils/phpstan-baseline/property.readOnlyByPhpDocAssignOutOfClass.neon b/utils/phpstan-baseline/property.readOnlyByPhpDocAssignOutOfClass.neon
diff --git a/utils/phpstan-baseline/property.readOnlyByPhpDocDefaultValue.neon b/utils/phpstan-baseline/property.readOnlyByPhpDocDefaultValue.neon

Original file line number	Diff line number	Diff line change
`@@ -17,8 +17,6 @@`
`17`	`17`	`*`
`18`	`18`	`* NOTE: This class is required prior to Autoloader instantiation,`
`19`	`19`	`* and does not extend BaseConfig.`
`20`		`- *`
`21`		`- * @immutable`
`22`	`20`	`*/`
`23`	`21`	`class Autoload extends AutoloadConfig`
`24`	`22`	`{`
Original file line number	Diff line number	Diff line change
`@@ -2,9 +2,6 @@`
`2`	`2`
`3`	`3`	`namespace Config;`
`4`	`4`
`5`		`-/**`
`6`		`- * @immutable`
`7`		`- */`
`8`	`5`	`class DocTypes`
`9`	`6`	`{`
`10`	`7`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -3,8 +3,6 @@`
`3`	`3`	`namespace Config;`
`4`	`4`
`5`	`5`	`/**`
`6`		`- * Mimes`
`7`		`- *`
`8`	`6`	`* This file contains an array of mime types. It is used by the`
`9`	`7`	`* Upload class to help identify allowed file types.`
`10`	`8`	`*`
`@@ -15,8 +13,6 @@`
`15`	`13`	`*`
`16`	`14`	`* When working with mime types, please make sure you have the ´fileinfo´`
`17`	`15`	`* extension enabled to reliably detect the media types.`
`18`		`- *`
`19`		`- * @immutable`
`20`	`16`	`*/`
`21`	`17`	`class Mimes`
`22`	`18`	`{`
Original file line number	Diff line number	Diff line change
`@@ -9,8 +9,6 @@`
`9`	`9`	`*`
`10`	`10`	`* NOTE: This class is required prior to Autoloader instantiation,`
`11`	`11`	`* and does not extend BaseConfig.`
`12`		`- *`
`13`		`- * @immutable`
`14`	`12`	`*/`
`15`	`13`	`class Modules extends BaseModules`
`16`	`14`	`{`
Original file line number	Diff line number	Diff line change
`@@ -7,8 +7,6 @@`
`7`	`7`	`*`
`8`	`8`	`* NOTE: This class does not extend BaseConfig for performance reasons.`
`9`	`9`	`* So you cannot replace the property values with Environment Variables.`
`10`		`- *`
`11`		`- * @immutable`
`12`	`10`	`*/`
`13`	`11`	`class Optimize`
`14`	`12`	`{`
Original file line number	Diff line number	Diff line change
`@@ -15,8 +15,6 @@`
`15`	`15`	`*`
`16`	`16`	`* NOTE: This class is required prior to Autoloader instantiation,`
`17`	`17`	`* and does not extend BaseConfig.`
`18`		`- *`
`19`		`- * @immutable`
`20`	`18`	`*/`
`21`	`19`	`class Paths`
`22`	`20`	`{`