Skip to content

remove $psr4['Tests\Support'] definition in application\Config\Autoload::__construct() #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Nov 6, 2018

Actually, the Config\Autoload class in application\Config directory is extends the CodeIgniter\Config\AutoloadConfig which in the __construct() already set $this->psr4['Tests\Support'] and it called the:

parent::__construct();

early, so it is no longer needed to be redefined as it will be merged with:

$this->psr4     = array_merge($this->psr4, $psr4);

which merge parent psr4 property to its $psr4 variable. So, I removed its definition in Config\Autoload::__construct().

Checklist:

  • Securely signed commits

@lonnieezell
Copy link
Member

Good catch. Looks like we need to update AutoloadConfig to respect the TESTPATH constant.

Could you add that this PR?

@samsonasik samsonasik force-pushed the remove-psr4-test-in-app branch from 1510268 to 40900db Compare November 6, 2018 14:41
@samsonasik
Copy link
Member Author

there is SUPPORTPATH constant, I updated to use SUPPORTPATH in AutoloadConfig class.

@lonnieezell
Copy link
Member

Forgot about that one! Thanks.

@lonnieezell lonnieezell merged commit 0674657 into codeigniter4:develop Nov 6, 2018
@samsonasik samsonasik deleted the remove-psr4-test-in-app branch November 6, 2018 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants