Deprecate BaseCommand::getPad and add more tests #3561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGatner
approved these changes
Aug 29, 2020
|
@MGatner all tests green 🎉 |
|
I see what you did there 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the changes brought by #3435 , the method
BaseCommand::getPadis not used anymore. I've checked for usage references within the codebase using VSCode and found none. This was because it was replaced bysetPad. Since this is a public function, I'm proposing to deprecate this.Also, with that PR's changes, some lines got uncovered by tests. So I've added a test for that.
Checklist: