Skip to content

Update BaseHandler::getEXIF #3568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2020
Merged

Update BaseHandler::getEXIF #3568

merged 1 commit into from
Aug 30, 2020

Conversation

paulbalandan
Copy link
Member

Description
I think this was on overlooking before, but the $silent param serves to silence our own exception, but there's no exception there.

Adding the error suppression @ will solve this: https://forum.codeigniter.com/thread-76417.html

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

MGatner
MGatner approved these changes Aug 30, 2020
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting tests

@MGatner MGatner merged commit e5a55e3 into codeigniter4:develop Aug 30, 2020
@paulbalandan paulbalandan deleted the getexif branch August 30, 2020 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbalandan @MGatner