Skip to content

[Cache] Allow covariant returns and optimize code #4635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2021
Merged

[Cache] Allow covariant returns and optimize code #4635

merged 1 commit into from
May 2, 2021

Conversation

paulbalandan
Copy link
Member

Description

  • Allow covariant return types in docblocks of Cache handlers
  • Simplify other code

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Conforms to style guide

MGatner
MGatner approved these changes May 2, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup. It has come to my attention that I missed MockCache in my recent round of changes. However that class needs a bit more work to be an appropriate Mock, so if you don't get to it for this PR I will mimic your changes there when I do it.

@paulbalandan paulbalandan merged commit 50a1e8b into codeigniter4:develop May 2, 2021
@paulbalandan paulbalandan deleted the cache-handler-optimize branch May 2, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbalandan @MGatner