Skip to content

Phpdoc param return types #4802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2021
Merged

Phpdoc param return types #4802

merged 3 commits into from
Jun 9, 2021

Conversation

paulbalandan
Copy link
Member

Description
Changes to PHPDocs:

  • use short forms (bool instead of boolean, etc.)
  • Align phpdocs
  • Separate and group similar phpdocs (removes Laravel-like docblocks)

Checklist:

  • Securely signed commits

MGatner
MGatner approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much yes!

@paulbalandan paulbalandan merged commit 2b95624 into codeigniter4:develop Jun 9, 2021
@paulbalandan paulbalandan deleted the phpdoc-param-return-types branch June 9, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @samsonasik @MGatner