Skip to content

Other PHPUnit-related fixers #4871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 25, 2021

Conversation

paulbalandan
Copy link
Member

Description
Configures other PHPUnit-related fixers.

The last one, php_unit_strict, will be done separately as it requires others to be merged and it would require a lot of fixing test failures.

Checklist:

  • Securely signed commits

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through and added all those voids when we updated to PHPUnit 9, only to find out later that I should have changed the scope as well. Always meant to go back for it - glad to see this happen!

@paulbalandan paulbalandan merged commit 7e21104 into codeigniter4:develop Jun 25, 2021
@paulbalandan paulbalandan deleted the phpunit-others branch June 25, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants