Skip to content

Enable explicit_indirect_variable #4881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2021
Merged

Enable explicit_indirect_variable #4881

merged 2 commits into from
Jun 28, 2021

Conversation

paulbalandan
Copy link
Member

Description
Add curly braces to indirect variables to make them clear to understand.

Checklist:

  • Securely signed commits

MGatner
MGatner approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably wouldn't have chosen this but it does seem to be for the best. Variable methods and variables are often overlooked when scanning code, this makes that very certain it won't happen. 😵‍💫

@paulbalandan paulbalandan merged commit 308d0be into codeigniter4:develop Jun 28, 2021
@paulbalandan paulbalandan deleted the explicit-indirect-variable branch June 28, 2021 14:10
element-code pushed a commit to element-code/CodeIgniter4 that referenced this pull request Aug 2, 2021
@paulbalandan @element-code
Enable explicit_indirect_variable (codeigniter4#4881)
ddbf0ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbalandan @MGatner