Skip to content

Delete docs directly, not api/docs #4976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Jul 28, 2021

Description
Apparently, #4969 only fixed half of the problem (which is the git reset). However, the actual contents of api/docs are not removed really. Analysing the logs from the verbose rm and mkdir, it shows that:

HEAD is now at 13c5ef1 Update README.md
mkdir: created directory 'api'
mkdir: created directory 'api/docs'

This means that instead of deleting the contents of docs in the root api, it instead looks at api/docs at the root api, a problem of relative paths. This attempts to fix the issue completely.

Successful run (in pull request context):
https://github.com/codeigniter4/CodeIgniter4/actions/runs/1075571421

Checklist:

  • Securely signed commits

@paulbalandan paulbalandan merged commit 3ab3ade into codeigniter4:develop Jul 28, 2021
@paulbalandan paulbalandan deleted the follow-up-apidocs branch July 28, 2021 16:15
element-code pushed a commit to element-code/CodeIgniter4 that referenced this pull request Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant