Skip to content

Improve tests/README.md #5221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2021
Merged

Improve tests/README.md #5221

merged 2 commits into from
Oct 21, 2021

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 20, 2021

Description

  • update PHPUnit version
  • add link to the user guide
  • fix Markdown decoration

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

MGatner
MGatner requested changes Oct 20, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! One tweak, then feel free to merge.

@kenjis kenjis merged commit 9a87de8 into codeigniter4:develop Oct 21, 2021
@kenjis kenjis deleted the fix-tests-readme branch October 21, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner requested changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @MGatner @paulbalandan