Skip to content

Optimize validation tests #5282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 8, 2021

Conversation

paulbalandan
Copy link
Member

Description

  • Add type declarations
  • Remove unnecessary multilines, whitespaces, comments
  • Use generators in data providers (for efficient memory consumption)
  • Move database related rules testing into own file (to reduce DB load on non-DB tests)
  • Group several related tests using a data provider (for scalability of testing)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@MGatner
Copy link
Member

MGatner commented Nov 6, 2021

All good rubrics and the tests are passing so I won't go through it all. I do like @kenjis suggestions. Mention me if you need anything else.

@paulbalandan paulbalandan force-pushed the optimize-validation-tests branch from 5869bb6 to a4c627e Compare November 7, 2021 10:54
@paulbalandan paulbalandan requested a review from kenjis November 7, 2021 16:22
@kenjis kenjis merged commit 96df6a8 into codeigniter4:develop Nov 8, 2021
@paulbalandan paulbalandan deleted the optimize-validation-tests branch November 9, 2021 00:11
@kenjis kenjis added the testing Pull requests that changes tests only label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Pull requests that changes tests only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants