Skip to content

chore: add script to add "Edit this page" button in User Guide #5352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 18, 2021

Description

  • make PRs easier

After generation of the User Guide.

$ user_guide_src/add-edit-this-page user_guide_src/build/html/

"Edit this page" buttons are added in the HTML files.
Screenshot 2021-11-18 17 01 48

Click the button, go to GitHub edit page.
Screenshot 2021-11-18 17 02 04

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis force-pushed the user_guide_src/add-edit-this-page branch from 267ad1b to 29047e9 Compare November 22, 2021 02:17
@kenjis
Copy link
Member Author

kenjis commented Nov 22, 2021

@paulbalandan I've changed the way of outputting filenames.
And squashed the commits.
Sorry to be difficult to review.

@kenjis kenjis requested a review from paulbalandan November 22, 2021 02:19
@paulbalandan paulbalandan merged commit 6ba7f27 into codeigniter4:develop Nov 22, 2021
@kenjis kenjis deleted the user_guide_src/add-edit-this-page branch November 22, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants