[Rector] Apply Option::PARALLEL to speed up analyze #5523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It works 🎉 Github uses 2 Core so its improvement is 2x faster. Before: 5m5s, ref https://github.com/codeigniter4/CodeIgniter4/runs/4674999414?check_suite_focus=true#step:10:4
After: 2m36s, ref https://github.com/codeigniter4/CodeIgniter4/runs/4681175691?check_suite_focus=true#step:10:1
|
|
All green 🎉 |
paulbalandan
approved these changes
Jan 2, 2022
kenjis
approved these changes
Jan 2, 2022
|
@samsonasik This is amazing! Thanks for being on top of all the latest. Would you apply any relevant changes to https://github.com/codeigniter4/devkit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rector 0.12.10 has new
Option::PARALLELto speed up process, It now requirePsr4to be applied in tests to avoidClass was not foundnotice, ref rectorphp/rector#6903Checklist: