Skip to content

chore: update deptrac config file #5964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 5, 2022

Description

  • update deptrac config file
Copying deptrac-0.20.0.phar to /usr/local/bin/deptrac


In FileLocator.php line 60:
                                                                               
  The file "deptrac.yaml" does not exist (in: "/home/runner/work/CodeIgniter4  
  /CodeIgniter4").    

https://github.com/codeigniter4/CodeIgniter4/runs/6302847835?check_suite_focus=true

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the github_actions Pull requests that update Github_actions code label May 5, 2022
@kenjis kenjis requested a review from MGatner May 5, 2022 08:35
@MGatner
Copy link
Member

MGatner commented May 5, 2022

That's odd; looks like maybe they changed the config file name in a minor release? I will ask them about it, because we will need to update DevKit and website and other paces as well. This looks good though.

@kenjis
Copy link
Member Author

kenjis commented May 5, 2022

The version is still under 1.0. So breaking changes are okay.
But there is no info/docs about it. It is not good.

@kenjis kenjis merged commit d554e20 into codeigniter4:develop May 5, 2022
@kenjis kenjis deleted the update-deptrac branch May 5, 2022 13:00
@totoprayogo1916 totoprayogo1916 mentioned this pull request Jul 12, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants