Skip to content

chore: update Sphinx version #6062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2022
Merged

chore: update Sphinx version #6062

merged 1 commit into from
Jun 3, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 1, 2022

Description

  • update sphinx, sphinxcontrib-phpdomain

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis
Copy link
Member Author

kenjis commented Jun 1, 2022

I've update Sphinx version on my local, but still :php:meth does not work.

:php:meth:`Response::setCookie() <CodeIgniter\\HTTP\\Response::setCookie>`

See https://github.com/markstory/sphinxcontrib-phpdomain#quick-sample

MGatner
MGatner approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about the class issue but the version bump seems good.

@kenjis kenjis merged commit a1b9b83 into codeigniter4:develop Jun 3, 2022
@kenjis kenjis deleted the update-sphinx branch October 2, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @MGatner @paulbalandan