Skip to content

docs: drop git installation #6318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jul 30, 2022

Description
Fixes #4043

Git installation is not recommened.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Jul 31, 2022
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ditch "a number" since we are only listing two. I like saying "supported" as a way of indicating that there are other methods but don't come asking for help with them 🫣

@@ -3,8 +3,7 @@ Installation
############

CodeIgniter4 can be installed in a number of different ways: manually,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeIgniter has two supported installation methods: manual download

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"supported" is good expression!

Done.

@kenjis kenjis force-pushed the fix-docs-remove-install-git branch from f94b076 to 98c333f Compare August 1, 2022 01:08
It is not recommended.
@kenjis kenjis force-pushed the fix-docs-remove-install-git branch from 98c333f to d3562d1 Compare August 1, 2022 01:10
@kenjis kenjis requested a review from MGatner August 1, 2022 01:10
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more tweak then it's good by me.

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@kenjis kenjis merged commit 170d84a into codeigniter4:develop Aug 1, 2022
@kenjis kenjis deleted the fix-docs-remove-install-git branch August 1, 2022 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Step installation method by Git
3 participants