Skip to content

chore: add extensions for suggest in composer.json #6322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 1, 2022

Description

  • add extentions for suggest

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
Copy link
Member Author

kenjis commented Aug 1, 2022

ext-xml is not listed in composer.json, but it is checked in CodeIgniter.php
I'm not sure xml is really needed.

CodeIgniter4/CodeIgniter.php at develop · codeigniter4/CodeIgniter4

$requiredExtensions = [
'curl',
'intl',
'json',
'mbstring',
'xml',
];

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update user_guide/intro/requirements.html? We have some inconsistencies between here and there about what is "required" versus "suggested".

@MGatner
Copy link
Member

MGatner commented Aug 1, 2022

I'm not sure xml is really needed.

Sorry, missed this comment before review.

@kenjis
Copy link
Member Author

kenjis commented Aug 1, 2022

what is "required" versus "suggested".

I think curl is suggested. It is needed only if you use CURLRequest.

@paulbalandan paulbalandan changed the title chore: add extentions for suggest in composer.json chore: add extensions for suggest in composer.json Aug 2, 2022
@kenjis kenjis force-pushed the add-suggest-ext branch 3 times, most recently from f4f6f8d to 4aa29f3 Compare August 4, 2022 02:20
@MGatner MGatner merged commit 8e02dbc into codeigniter4:develop Aug 5, 2022
@kenjis kenjis deleted the add-suggest-ext branch August 8, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants