Skip to content

docs: improve installation #6324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 2, 2022
Merged

docs: improve installation #6324

merged 12 commits into from
Aug 2, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 1, 2022

Description

  • add initial configuration in Installation pages
  • add note about baseURL and debug toolbar
  • small fixes

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Aug 1, 2022
MGatner
MGatner requested changes Aug 1, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A few tweaks.

kenjis and others added 3 commits August 2, 2022 16:00
@kenjis
Copy link
Member Author

kenjis commented Aug 2, 2022

@MGatner Thank you for proofreading!

@kenjis kenjis requested a review from MGatner August 2, 2022 07:02
@MGatner
Copy link
Member

MGatner commented Aug 2, 2022

Anytime! I know I've said it before: your English is incredibly strong for a non-native speaker!

Most of these corrections aren't actual problems so much as native phrasing, so if you ever get tired of my nitpicks then just tell me to stop 😅

@kenjis kenjis merged commit 4df89ed into codeigniter4:develop Aug 2, 2022
@kenjis kenjis deleted the fix-docs-installation branch August 2, 2022 23:03
@kenjis
Copy link
Member Author

kenjis commented Aug 2, 2022

No problem. Proofreading is welcome!
In fact we have only two active proofreaders now, you and Paul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @MGatner