Skip to content

config: change Security::$redirect to false #6406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 25, 2022
Merged

config: change Security::$redirect to false #6406

merged 3 commits into from
Aug 25, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 21, 2022 •
edited
Loading

Description
It is difficult to know what happened for (beginner) devs. See #6404 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the 4.3 label Aug 21, 2022
@kenjis kenjis mentioned this pull request Aug 21, 2022
Closed
kenjis added 2 commits August 22, 2022 15:59
@kenjis
config: change Securiry::$redirect to false
4375928 
It is difficult to know what happened for devs.
@kenjis
config: update env
7231498
@kenjis kenjis force-pushed the fix-csrf-redirect-default branch from 1b2d6a6 to 7231498 Compare August 22, 2022 07:00
MGatner
MGatner approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change!

@kenjis @MGatner
docs: fix typo
55bb2e5 
Co-authored-by: MGatner <[email protected]>
@MGatner MGatner changed the title config: change Securiry::$redirect to false config: change Security::$redirect to false Aug 23, 2022
@kenjis kenjis merged commit 44524ee into codeigniter4:4.3 Aug 25, 2022
@kenjis kenjis deleted the fix-csrf-redirect-default branch August 25, 2022 12:04
This was referenced Apr 5, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @datamweb @MGatner