Skip to content

docs: update about test database setup #6416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 25, 2022
Merged

docs: update about test database setup #6416

merged 3 commits into from
Aug 25, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 23, 2022

Description
There seems no reason to use phpunit.xml.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

MGatner
MGatner requested changes Aug 23, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep the mention of phpunit.xml - that is my preferred method (swapping between the .dist version).

@kenjis
Copy link
Member Author

kenjis commented Aug 23, 2022

Done!

@kenjis kenjis requested a review from MGatner August 23, 2022 11:30
paulbalandan
paulbalandan reviewed Aug 23, 2022
View reviewed changes
@kenjis @paulbalandan
docs: fix by proofreading
70d27e0 
Co-authored-by: John Paul E. Balandan, CPA <[email protected]>
@kenjis kenjis requested a review from paulbalandan August 24, 2022 02:17
MGatner
MGatner approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kenjis ❤️ Don't want to get on Sebastian Bergmann's bad side 🫣

@kenjis kenjis merged commit c3aa797 into codeigniter4:develop Aug 25, 2022
@kenjis kenjis deleted the fix-tests-README branch August 25, 2022 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @MGatner @paulbalandan