Skip to content

[Removed] feat: add Time::toDatabase() #6431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 28, 2022
Merged

[Removed] feat: add Time::toDatabase() #6431

merged 3 commits into from
Aug 28, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 27, 2022 •
edited
Loading

Description
Closes #6124

  • add Time::toDatabase()

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.3 labels Aug 27, 2022
@kenjis kenjis mentioned this pull request Aug 27, 2022
Merged
MGatner
MGatner approved these changes Aug 27, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

datamweb
datamweb reviewed Aug 27, 2022
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kenjis, please add a description in the user guide section.

@kenjis kenjis added the docs needed Pull requests needing documentation write-ups and/or revisions. label Aug 27, 2022
@kenjis kenjis removed the docs needed Pull requests needing documentation write-ups and/or revisions. label Aug 27, 2022
@kenjis
Copy link
Member Author

kenjis commented Aug 27, 2022

Added the docs.

datamweb
datamweb approved these changes Aug 27, 2022
View reviewed changes
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Kenjis!

MGatner
MGatner approved these changes Aug 28, 2022
View reviewed changes
@kenjis kenjis merged commit 596e443 into codeigniter4:4.3 Aug 28, 2022
@kenjis kenjis deleted the feat-Time-toDatabase branch August 28, 2022 10:38
@kenjis kenjis mentioned this pull request Aug 29, 2022
Closed
@kenjis kenjis mentioned this pull request Sep 8, 2022
Merged
3 tasks
@kenjis kenjis removed the enhancement PRs that improve existing functionalities label Sep 8, 2022
@kenjis kenjis changed the title feat: add Time::toDatabase() [Removed] feat: add Time::toDatabase() Sep 8, 2022
@kenjis
Copy link
Member Author

kenjis commented Sep 8, 2022

This feature was removed by #6509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @datamweb @MGatner