Skip to content

docs: deprecate Cookie::withNeverExpiring() #6463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Aug 31, 2022

Description
See #6413
Supersedes #6413

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this count as docs:?

@@ -461,6 +461,8 @@ public function withExpired()

/**
* {@inheritDoc}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop this since you're here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@kenjis kenjis force-pushed the deprecate-Cookie-withNeverExpiring branch from 9ab4a36 to dcd4ab9 Compare September 2, 2022 02:38
@kenjis kenjis merged commit 3eb0ea4 into codeigniter4:develop Sep 2, 2022
@kenjis kenjis deleted the deprecate-Cookie-withNeverExpiring branch September 2, 2022 22:02
@kenjis kenjis mentioned this pull request Sep 2, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants