Skip to content

docs: add composer.json in Mandatory File Changes in upgrade_420.rst #6476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 2, 2022

Description

  • add about composer.json autoload.psr-4

The config makes spark migrate:status output duplicated.
The same explanation is already here: https://codeigniter4.github.io/CodeIgniter4/general/managing_apps.html
But it is better to have it in Upgrading Guide.

The following is the result of installing v4.1.5 and updated to v4.2.5:

$ php spark migrate:status

CodeIgniter v4.2.5 Command Line Tool - Server Time: 2022-09-02 18:25:16 UTC-05:00

+-----------+-------------------+----------+-------+-------------+-------+
| Namespace | Version           | Filename | Group | Migrated On | Batch |
+-----------+-------------------+----------+-------+-------------+-------+
| App       | 2022-09-02-231945 | Test     | ---   | ---         | ---   |
| App       | 2022-09-02-231945 | Test     | ---   | ---         | ---   |
+-----------+-------------------+----------+-------+-------------+-------+

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Sep 2, 2022
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's the source of the duplicate migrations! Very interesting.

@kenjis
Copy link
Member Author

kenjis commented Sep 3, 2022

Yes, App namespace is registered twice, and it shows migrations twice.

@kenjis kenjis merged commit 9cbe0a2 into codeigniter4:develop Sep 3, 2022
@kenjis kenjis deleted the fix-docs-upgrade_420.rst branch September 3, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants