Create Forge::dropPrimaryKey() #6488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method drops a primary key on an existing table
This method removes primary key from Table class preventing the primary key from being recreated.
This method uses the Sqlite Table class to dop the primary key
sclubricants
added
enhancement
MGatner
approved these changes
Sep 4, 2022
|
@sclubricants Related to my last comment, I am working on putting together a team for database reviews and issues: https://forum.codeigniter.com/showthread.php?tid=82920 Would you be willing to join this team? It wouldn't be much different than how things are now, but you might get more requests to look at database Pull Requests. Any participation is of course optional (we're all volunteers here). Your expertise would be very welcome! |
|
@MGatner Sure, be glad to help. Im working on a PDO/ODBC driver as we speak. ODBC gets messy. I half way built one a while back but it needs a lot of work. Would be great to have it as part of CI. I use it a lot. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a method to drop primary keys from a table.
This is the second part of #6430
This solves part of #4653
Checklist: