-
Notifications
You must be signed in to change notification settings - Fork 1.9k
docs: improve session #6593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve session #6593
Conversation
userdata() method does not exist in CI4
This is a historical explanation.
`userdata` does not make sense in CI4.
Move to a more appropriate location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the UG used "userdata" throughout to indicate "non-flash data stored by the framework", because some actual $_SESSION
items are not included:
$_exclude = array_merge(['__ci_vars'], $this->getFlashKeys(), $this->getTempKeys());
I'm fine with making this a little more opaque but we should note somewhere what is not included.
Otherwise: I am in favor of encouraging use of the Session handler over the global variable.
There are some notes (important) to describe the items that the
And I added a note for the word "userdata". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed those other comments. Thank you for updating. LGTM!
Description
Small improvements or fixes.
If we agree, I would like to remve all sample code that uses
$_SESSION
directly.Checklist: