Skip to content

docs: add Warning to $routes->map() #6613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 1, 2022
Merged

docs: add Warning to $routes->map() #6613

merged 3 commits into from
Oct 1, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 1, 2022

Description

  • The map() method is not recommended as well as add() because it calls add() internally.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

kenjis added 3 commits October 1, 2022 11:12
@kenjis
docs: move "Mapping Multiple Routes" down
0578fdc 
add() is now not recommended, and described below.
@kenjis
docs: move Warning up
3c4a341 
To make stand out.
@kenjis
docs: add Warning to map()
67f48dc
@kenjis kenjis added the documentation Pull requests for documentation only label Oct 1, 2022
MGatner
MGatner approved these changes Oct 1, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe map() needs an additional parameter for $method?

@kenjis kenjis merged commit 86d0f3d into codeigniter4:develop Oct 1, 2022
@kenjis kenjis deleted the fix-docs-routing.rst branch October 1, 2022 12:53
@kenjis
Copy link
Member Author

kenjis commented Oct 1, 2022

HTTP method and optional route name seem to be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
documentation Pull requests for documentation only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @datamweb @MGatner