Skip to content

fix: TestCaseTest::testStreamFilter fails on Windows #6706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2022
Merged

fix: TestCaseTest::testStreamFilter fails on Windows #6706

merged 1 commit into from
Oct 18, 2022

Conversation

paulbalandan
Copy link
Member

Description
Code uses PHP_EOL but test uses "\n", so it fails on Windows.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added testing Pull requests that changes tests only 4.3 labels Oct 17, 2022
MGatner
MGatner approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paulbalandan paulbalandan merged commit aed1eb1 into codeigniter4:4.3 Oct 18, 2022
@paulbalandan paulbalandan deleted the line-ending branch October 18, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @kenjis @MGatner