Skip to content

Add template types to PreparedQuery #6708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2022
Merged

Add template types to PreparedQuery #6708

merged 2 commits into from
Oct 18, 2022

Conversation

paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Oct 18, 2022 •
edited
Loading

Description
Making PreparedQuery a generic type, thus extensions need to specify the type of the statement.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the 4.3 label Oct 18, 2022
@paulbalandan paulbalandan force-pushed the prepared-query-template-types branch from a9d59be to 64e26f8 Compare October 18, 2022 04:25
kenjis
kenjis approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulbalandan paulbalandan changed the title Add template types to PreparedQuery Add template types to PreparedQuery Oct 18, 2022
MGatner
MGatner approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice generics-fu!

@paulbalandan paulbalandan merged commit 0831f15 into codeigniter4:4.3 Oct 18, 2022
@paulbalandan paulbalandan deleted the prepared-query-template-types branch October 18, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulbalandan @kenjis @MGatner