Auto-review tests to enforce @group annotations
#6772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbalandan
force-pushed
the
auto-review-group
branch
from
803bff9 to
cd7bf55
Compare
|
Under deliberation at the other PR. |
paulbalandan
force-pushed
the
auto-review-group
branch
from
cd7bf55 to
f96b933
Compare
MGatner
reviewed
Nov 5, 2022
|
Not sure, but > vendor/bin/phpunit --list-groups
PHPUnit 9.5.26 by Sebastian Bergmann and contributors.
Available test group(s):
- AutoReview
- Others
- SeparateProcess
- default |
paulbalandan
force-pushed
the
auto-review-group
branch
from
f96b933 to
8f5528f
Compare
That's very odd! I will do a little digging. |
|
I got nothing; everything looks correct to me. I think we proceed with this and then troubleshoot some more if the groups aren't actually working. |
MGatner
approved these changes
Nov 6, 2022
|
I did some testing on the |
$ vendor/bin/phpunit --list-groups
PHPUnit 9.5.26 by Sebastian Bergmann and contributors.
Available test group(s):
- AutoReview
- Others
- SeparateProcess
- default |
|
Cannot merge this for now. Coverage decreased to 15.9%. 🤯 |
|
This is not a bug of PHPUnit. Testing with a minimal repo lists all groups as expected. So it has something to do with the current phpunit.xml.dist and the changes to it. |
paulbalandan
force-pushed
the
auto-review-group
branch
from
8f5528f to
9c60327
Compare
|
I am so confused why the tests hang! 😤 |
paulbalandan
force-pushed
the
auto-review-group
branch
from
9c60327 to
15225f6
Compare
$ vendor/bin/phpunit --list-groups
PHPUnit 9.5.26 by Sebastian Bergmann and contributors.
Available test group(s):
- AutoReview
- CacheLive
- DatabaseLive
- Others
- SeparateProcess |
MGatner
reviewed
Nov 10, 2022
MGatner
approved these changes
Nov 10, 2022
kenjis
approved these changes
Nov 11, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Needs #6770 for tests to pass.
Code based on my private repo.
Checklist: