Skip to content

fix: Model cannot insert when $useAutoIncrement is false #6827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 8, 2022
Merged

fix: Model cannot insert when $useAutoIncrement is false #6827

merged 3 commits into from
Nov 8, 2022

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 7, 2022 •
edited
Loading

Description
From https://forum.codeigniter.com/showthread.php?tid=84733

  • The $primaryKey field should never be an allowed field.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Nov 7, 2022
MGatner
MGatner reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change. I've been using a workaround in a base Model in a project that uses UUIDs so I didn't even notice that this was an issue!

system/Model.php Outdated
*
* @var int|string|null
*/
private $tempPrimaryKeyData;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "data"? If differentiating from the name I think "value" would be more consistent with what we usually do for a single item.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, value is better.
Fixed.

@kenjis kenjis merged commit ecac1ab into codeigniter4:develop Nov 8, 2022
@kenjis kenjis deleted the fix-model-useAutoIncrement-false branch November 8, 2022 23:18
@kenjis kenjis mentioned this pull request Dec 30, 2022
Closed
@MaulanaMalikS
Copy link

This also happens in the model's insertBatch() function.
Is there any progress on resolving this issue?

@kenjis
Copy link
Member Author

kenjis commented Jul 29, 2023

@MaulanaMalikS If you find another bug, please report it.
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/README.md

@MaulanaMalikS
Copy link

@kenjis I've made an issue for this #7744 .

@kenjis kenjis mentioned this pull request Aug 1, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @MaulanaMalikS @michalsn @MGatner