Skip to content

Fix ShowTableInfoTest to pass on Windows #6853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2022
Merged

Fix ShowTableInfoTest to pass on Windows #6853

merged 1 commit into from
Nov 15, 2022

Conversation

paulbalandan
Copy link
Member

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the testing Pull requests that changes tests only label Nov 13, 2022
kenjis
kenjis reviewed Nov 13, 2022
View reviewed changes
@paulbalandan paulbalandan requested a review from kenjis November 14, 2022 05:06
kenjis
kenjis approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good!

@kenjis kenjis merged commit 5558fe9 into codeigniter4:develop Nov 15, 2022
@paulbalandan paulbalandan deleted the fix-showtableinfotest branch November 15, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenjis kenjis kenjis approved these changes

@michalsn michalsn michalsn approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulbalandan @kenjis @michalsn @datamweb