-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: disable BaseBuilder::setAlias() #6871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since there is no consensus to make this method a public method, it will be put on hold.
What's wrong?
https://github.com/codeigniter4/CodeIgniter4/actions/runs/3475428925/jobs/5810650672 |
Not sure what those errors mean but it looks like you got it working. Let's see if we can hear back from @sclubricants, but I'm good with this PR if it expedited 4.3 |
Yes, I fixed the bug. I don't know why only OCI8 did not work, but my code was obviously wrong. |
I can understand not wanting to make thing public that aren't necessary. I do find it easier to code having the separate public method. The method chaining seems easier to remember than the parameters. It does make more logical sense to tie it to the setData() method though.. as the alias is sure to be tied to the dataset and not to something else. If in the future there is a need for multiple aliases then this might not work so well. |
@sclubricants I think the intent is to hide this now so we can finish discussing it without blocking the 4.3 release. I am looking to the Database Team to have most of that discussion, but I think this is a good temporary measure. |
Description
Since there is not yet a consensus to make this method a public API, it will be disabled when v4.3.0 is released.
See #6734 (comment)
Checklist: